Skip to content

Add replace self.init with Builtin.unreachable in Mirror #61422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Add replace self.init with Builtin.unreachable in Mirror #61422

merged 1 commit into from
Oct 4, 2022

Conversation

jakedves
Copy link
Contributor

@jakedves jakedves commented Oct 3, 2022

Replaced self.init calls with Builtin.unreachable() calls that was previously not allowed due to a (now fixed) issue. If you could have a look and run the CI bot, that would be appreciated @AnthonyLatsis, thanks.

Just a note I think that this change resulted in more "unsupported" test cases which may be something to check.

Resolves #61326

Previously unavailable due to #57622 (fixed)
@AnthonyLatsis AnthonyLatsis requested a review from Azoy October 3, 2022 22:43
@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Oct 3, 2022

Thanks, Jake. Did you run into a conflict? If so, could you rebase over an up-to-date main branch to avoid having this merge commit in the history?

Just a note I think that this change resulted in more "unsupported" test cases which may be something to check

Tests predefine the conditions in which they are skipped — an implementation detail is not expected to make a difference.

@jakedves
Copy link
Contributor Author

jakedves commented Oct 3, 2022

Hey Anthony, there wasn't a merge conflict, just a message that my fork was N commits behind main, and so I pulled those commits in. I'm not familiar with rebasing, sorry.

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Oct 3, 2022

there wasn't a merge conflict, just a message that my fork was N commits behind main

I see. Keep in mind that to test or merge a pull request, it shouldn’t matter how far behind your branch is as long as there are no conflicts with the target branch. Since there is no conflict, a rebase is not necessary. Could you simply hard-reset the merge commit?

@jakedves
Copy link
Contributor Author

jakedves commented Oct 4, 2022

Ok I think that's been done

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test

Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@Azoy Azoy merged commit 5c3459f into swiftlang:main Oct 4, 2022
@jakedves jakedves deleted the add-unreachable branch October 4, 2022 17:19
greenthings added a commit to greenthings/swift that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace init delegations in Mirror with calls to Builtin.unreachable() when reflection is disabled
3 participants