[AST] Move generic parameter logic for accessor decl from parser to GenericParamListRequest #61429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
slavapestov
reviewed
Oct 4, 2022
LucianoPAlmeida
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci Please test |
|
@slavapestov I think changes are ready for a re-review. Let me know if this aligns with what you were thinking |
LucianoPAlmeida
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractFunctionDecl::isGenericContextbeing based ongetGenericParams()which isnullptrin this case forAccessorDeclbecausecreateOpaqueParameterGenericParamswas not be able to create the implicit generic param list correctly because it was looking to itself but in fact it should look through subscript(storage) signature instead.This refectors generic parameters logic for accessor declaration to be a copy of the storage at
GenericParamListRequestinstead of parse time. See Slava's comment bellow.Resolves #61387