Skip to content

[Distributed] Fix signature mismatch in NotFoundError constructor #61470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 6, 2022

Fix signature mismatch for WebAssembly port, which doesn't allow such mismatch strictly.
Those extra parameters are not used in the definition, so just removed them from caller side.

@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test

@ktoso
Copy link
Contributor

ktoso commented Oct 7, 2022

Oh nice catch, thank you!

@kateinoigakukun kateinoigakukun marked this pull request as ready for review October 7, 2022 03:11
@kateinoigakukun kateinoigakukun merged commit 6fb7bcc into swiftlang:main Oct 7, 2022
@kateinoigakukun kateinoigakukun deleted the katei/fix-da-error-maker-sigs branch October 7, 2022 03:12
@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants