[Profiler] Clean up CounterExpr allocation #61474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a BumpPtrAllocator instead of a linked list, and allocate internally within the CounterExpr so we can just pass about values instead of pointers and references. This allows us to eliminate `CounterExpr::Ref`. Unfortunately this means we can no longer store CounterExprs in the SourceMappingRegions for nodes, as we were previously using pointers to propagate updates the counters made after the region was popped. Instead we now have to query the `CounterMap`. But IMO this is a worthwhile tradeoff for code that's easier to reason about.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a BumpPtrAllocator instead of a linked list, and allocate internally within the CounterExpr so we can just pass about values instead of pointers and references. This allows us to eliminate
CounterExpr::Ref.Unfortunately this means we can no longer store CounterExprs in the SourceMappingRegions for nodes, as we were previously using pointers to propagate updates the counters made after the region was popped. Instead we now have to query the
CounterMap. But IMO this is a worthwhile tradeoff for code that's easier to reason about.