Liveness cleanup - preparation for OSSA liveness #61475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want a short-circuit test for address types, that should be done within getOwnershipKind() itself.
|
@swift-ci test |
|
😒TEST 'lldb-api :: lang/swift/async/stepping/step-in/TestSwiftStepInAsync.py' FAILED |
|
@swift-ci smoke test macOS platform |
nate-chandler
approved these changes
Oct 6, 2022
This allows dynamic dispatch into the fast paths. It's also easier to understand the fast paths when written as separate loops. This way, we can used MultiDefPrunedLiveness to compute ownership liveness, but still benefit from the fact that the common case (owned non-phi value) is much simpler and faster to compute. This approach is necessary because we use stack-based data structures within the liveness result, so we need to statically instantiate something that can handle all cases.
atrick
force-pushed
the
liveness-cleanup
branch
from
ecad424 to
715d3f7
Compare
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main commit: Split PrunedLiveness::findBoundariesInBlock into fast paths