Runtime: split out extern "C" marker from SWIFT_RUNTIME_EXPORT
#61476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason we're still waiting on this? This is a growing problem for Linux builds. (On recent Ubuntu, "clang" defaults to clang-15, which trips over this.) |
|
@swift-ci Please test |
|
Trying to build locally on Linux with this change gives me: and a number of other similar-looking errors. |
tbkka
reviewed
Oct 21, 2022
| #else | ||
| #define SWIFT_EXPORT_FROM(LIBRARY) SWIFT_EXPORT_FROM_ATTRIBUTE(LIBRARY) |
There was a problem hiding this comment.
SWIFT_EXPORT_FROM() is used in several other places, so you cannot drop this definition.
There was a problem hiding this comment.
But SWIFT_EXPORT_FROM_ATTRIBUTE is not used outside of this file, so you could just rename that to SWIFT_EXPORT_FROM
| // SWIFT_RUNTIME_EXPORT is just SWIFT_EXPORT_FROM(swiftCore). | ||
| // | ||
| // TODO: use this in shims headers in overlays. | ||
| #define SWIFT_RUNTIME_EXPORT SWIFT_EXPORT_FROM_ATTRIBUTE(LIBRARY) |
There was a problem hiding this comment.
This should be SWIFT_EXPORT_FROM_ATTRIBUTE(swiftCore)
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Oct 28, 2022
This fix might be replaced by something better, e.g. swiftlang#61476
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Oct 31, 2022
This fix might be replaced by something better, e.g. swiftlang#61476
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Nov 3, 2022
This fix might be replaced by something better, e.g. swiftlang#61476
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Nov 4, 2022
This fix might be replaced by something better, e.g. swiftlang#61476
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Nov 4, 2022
This fix might be replaced by something better, e.g. swiftlang#61476
|
@swift-ci please test |
|
Re-testing this one in the hope of merging it soon. |
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Nov 8, 2022
This is required to a clang change. Attribute need to be in a certain order when building with a newer clang. This fix might be replaced by something better, e.g. swiftlang#61476
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Nov 8, 2022
This is required to a clang change. Attribute need to be in a certain order when building with a newer clang. This fix might be replaced by something better, e.g. swiftlang#61476
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Nov 9, 2022
This is required to a clang change. Attribute need to be in a certain order when building with a newer clang. This fix might be replaced by something better, e.g. swiftlang#61476
Although the runtime exported symbols must be exported with "C" linkage and decoration, we split out the externalisation in the C++ mode. This is required to ensure that we are able to attribute the functions without following the more stringent rules that clang now enforces which place the attributes following the identifier to which they appertain, resulting in the attributes interleaving within the signature. The resulting spelling is more difficult to process for humans as well as more difficult to identify as function declarations making code perusal a challenge, particularly for the uninitiated.
|
@swift-ci please test |
|
Closing in favour of fixing llvm/llvm-project#58229 (https://reviews.llvm.org/D137979) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the runtime exported symbols must be exported with "C" linkage and decoration, we split out the externalisation in the C++ mode. This is required to ensure that we are able to attribute the functions without following the more stringent rules that clang now enforces which place the attributes following the identifier to which they appertain, resulting in the attributes interleaving within the signature. The resulting spelling is more difficult to process for humans as well as more difficult to identify as function declarations making code perusal a challenge, particularly for the uninitiated.