[SILGen] TypeWrappers: Support default values in user-defined initializers #61479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
…Storage It was done in `maybeAddTypeWrapperDefaultArg` before because user-defined initializers weren't supported but now property initializers need to be subsumed earlier to make sure that SILGen doesn't try to emit them into user-defined initializers.
…izers All of the property initializers are injected as initializations of individual `_storage` fields.
xedin
force-pushed
the
type-wrappers-init-values-in-user-defined-inits
branch
from
ee99dc8 to
7dfad23
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
hborla
approved these changes
Oct 20, 2022
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the property initializers are injected as initializations
of individual
_storagefields.