Skip to content

[cxx-interop] Make some CxxSequence methods inlinable #61484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

[cxx-interop] Make some CxxSequence methods inlinable #61484

merged 1 commit into from
Oct 13, 2022

Conversation

egorzhdan
Copy link
Contributor

No description provided.

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Oct 7, 2022
@egorzhdan
Copy link
Contributor Author

@swift-ci please benchmark

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test macOS

1 similar comment
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test macOS

@egorzhdan
Copy link
Contributor Author

@swift-ci please benchmark

@egorzhdan egorzhdan requested review from hyp and zoecarver October 13, 2022 11:44
@egorzhdan
Copy link
Contributor Author

Performance (x86_64): -O

Regression OLD NEW DELTA RATIO
FlattenListFlatMap 3076 3541 +15.1% 0.87x (?)

Code size: -O

Performance (x86_64): -Osize

Improvement OLD NEW DELTA RATIO
CxxVecU32.sum.Swift.subscriptLoop 76 48 -36.8% 1.58x
CxxVecU32.sum.Swift.iteratorLoop 76 48 -36.8% 1.58x (?)

Code size: -Osize

Performance (x86_64): -Onone

Code size: -swiftlibs

@egorzhdan egorzhdan merged commit 9b8f7e4 into main Oct 13, 2022
@egorzhdan egorzhdan deleted the egorzhdan/cxx-sequence-inlinable branch October 13, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyp hyp Awaiting requested review from hyp

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@egorzhdan