Runtime: correct attribute annotations for newer compilers #61489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`extern "C"` *must* precede any attributes. We were previously incorrectly applying the attributes to the declaration that was marked as `extern "C"` in C++ contexts. Reorder the attributes to correct this oversight allowing compilation with newer clang releases.
|
@swift-ci please smoke test |
|
FYI: I had already tried this before the solution I came to in #61473, and it didn't work with our more modern internal Clang. I got the same errors about positioning as before: |
|
https://godbolt.org/z/eac6PYW73 seems to indicate that it should work with clang trunk and that gcc also behaves identically. |
|
The full code with the macros in place does not work, however: https://godbolt.org/z/9cc53PocK |
|
https://godbolt.org/z/ov9e53KMq reduced test case - seems like a clang issue |
|
Verified that this is a rejects-valid case: llvm/llvm-project#58229 |
|
Closing in favour of fixing llvm/llvm-project#58229 (https://reviews.llvm.org/D137979) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extern "C"must precede any attributes. We were previously incorrectly applying the attributes to the declaration that was marked asextern "C"in C++ contexts. Reorder the attributes to correct this oversight allowing compilation with newer clang releases.