[SILOptimizer] Add deinit-barrier side-effect. #61495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar90412220
branch
5 times, most recently
from
95a441b to
33f71f7
Compare
nate-chandler
force-pushed
the
rdar90412220
branch
from
33f71f7 to
2c90ce5
Compare
nate-chandler
force-pushed
the
rdar90412220
branch
2 times, most recently
from
4dc3dcf to
6cb48bc
Compare
|
@swift-ci please test |
eeckstein
requested changes
Oct 17, 2022
SwiftCompilerSources/Sources/Optimizer/Analysis/CalleeAnalysis.swift
Outdated
Show resolved
Hide resolved
SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ComputeSideEffects.swift
Outdated
Show resolved
Hide resolved
nate-chandler
force-pushed
the
rdar90412220
branch
3 times, most recently
from
e1ec516 to
9fbd4cb
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
rdar90412220
branch
2 times, most recently
from
ccf9a6b to
21bca72
Compare
Added new C++-to-Swift callback for isDeinitBarrier. And pass it CalleeAnalysis so it can depend on function effects. For now, the argument is ignored. And, all callers just pass nullptr. Promoted to API the mayAccessPointer component predicate of isDeinitBarrier which needs to remain in C++. That predicate will also depends on function effects. For that reason, it too is now passed a BasicCalleeAnalysis and is moved into SILOptimizer. Also, added more conservative versions of isDeinitBarrier and maySynchronize which will never consider side-effects.
Functions "are deinit barriers" (more pedantically, applies of functions are deinit barriers) if any of their instructions are deinit barriers. During side-effect analysis, when walking a function's instructions for other global effects, also check for the deinit-barrier effect. If an instruction is found to be a deinit barrier, mark the function's global effects accordingly. Add SILFunction::isDeinitBarrier to conveniently access the effects computed during ComputeSideEffects. Update the isBarrierApply predicate to iterate over the list of callees, if complete, to check whether any is a deinit barrier. If none is, then the apply is not a deinit barrier.
Checked that applies of empty functions, or their callees, or their callees' callees, are not deinit barriers. Checked that applies of unknown functions, or their callees, or their callees' calles, are deinit barriers.
Pass a BasicCalleeAnalysis instance to isDeinitBarrier. This will enable SSADestroyHoisting to hoist destroy_addrs over applies of functions that are not themselves deinit barriers.
Pass a BasicCalleeAnalysis instance to isDeinitBarrier. This will allow ShrinkBorrowScope to hoist end_borrows over applies of functions which are not deinit barriers.
Pass a BasicCalleeAnalysis instance to isDeinitBarrier. This enables LexicalDestroyHoisting to hoist destroys over applies of functions which are not deinit barriers.
nate-chandler
force-pushed
the
rdar90412220
branch
from
21bca72 to
4b85d0a
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please benchmark |
|
@swift-ci please clean test macOS platform |
1 similar comment
|
@swift-ci please clean test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computed whether a function counts as a deinit barrier during ComputeSideEffects. Hoisted
destroy_addrs of lexical addresses,destroy_values of owned lexical values, andend_borrows of lexicalbegin_borrows over applies of functions which are not deinit barriers.