Skip to content

[Profiler] Minor cleanup #61519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2022
Merged

[Profiler] Minor cleanup #61519

merged 2 commits into from
Oct 10, 2022

Conversation

hamishknight
Copy link
Contributor

No description provided.

@hamishknight
[Profiler] NFC: Rename assignCounter -> assignKnownCounter
89145f3 
Make it clearer that we expect an existing counter
to have been assigned by MapRegionCounters.
@hamishknight
[Profiler] Remove getProfilerContextForDecl
04ef945 
We can use `getInnermostDeclContext` instead. Also
tighten up the condition of `hasFileBeenTypeChecked`
a bit.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit 76b893d into swiftlang:main Oct 10, 2022
@hamishknight hamishknight deleted the minor-cleanup branch October 10, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hamishknight