[cxx-interop] Correctly check iterator conformances #61540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test macOS |
egorzhdan
force-pushed
the
egorzhdan/cxx-iterator-opaque-ptr
branch
from
3366b47 to
b8fd75d
Compare
|
@swift-ci please smoke test |
To determine whether to conform a C++ type to `CxxSequence` protocol automatically, ClangImporter checks if the corresponding iterator type conforms to `UnsafeCxxInputIterator`. This logic had false-positives, e.g. `Optional<OpaquePointer>` was treated as if it conforms to `UnsafeCxxInputIterator` while it actually doesn't. This happened because `lookupConformance` returned a conformance with a conditional requirement (`Wrapped : UnsafeCxxInputIterator`) that is not satisfied for `OpaquePointer`. rdar://100265664
egorzhdan
force-pushed
the
egorzhdan/cxx-iterator-opaque-ptr
branch
from
b8fd75d to
c53b814
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine whether to conform a C++ type to
CxxSequenceprotocol automatically, ClangImporter checks if the corresponding iterator type conforms toUnsafeCxxInputIterator.This logic had false-positives, e.g.
Optional<OpaquePointer>was treated as if it conforms toUnsafeCxxInputIteratorwhile it actually doesn't. This happened becauselookupConformancereturned a conformance with a conditional requirement (Wrapped : UnsafeCxxInputIterator) that is not satisfied forOpaquePointer.rdar://100265664