Skip to content

Use AccessPath exact use visitor in LoadBorrowImmutabilityChecker #61549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

Use AccessPath exact use visitor in LoadBorrowImmutabilityChecker #61549

merged 1 commit into from
Oct 13, 2022

Conversation

meg-gupta
Copy link
Contributor

Since we were visiting overlapping uses, we ended up seeing unrelated access path uses. For verification purpose, we need only an exact use visitor.

@meg-gupta meg-gupta requested a review from atrick October 11, 2022 22:55
@meg-gupta
Copy link
Contributor Author

@swift-ci test

atrick
atrick approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 0421c1b into swiftlang:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meg-gupta @atrick @swift-ci