[Profiler] Introduce ProfileCounterRef #61566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a case where we know we don't have a profiler, and avoid incrementing for a distributed factory method. Otherwise such cases could pass a null ASTNode, which will become an assertion failure in a future commit. While we're here, let's standardize on emitting the profiler increment for function entry after the prolog, as if there's e.g an unreachable parameter, the increment can be safely elided anyway.
This will become an assertion failure in a future commit.
For now this just wraps an ASTNode, but in the future it will allow us to model counters that cannot simply hang off ASTNodes, e.g error branch counters.
Also bump the copyright year.
hamishknight
force-pushed
the
countdown
branch
from
de99a63 to
b4d4137
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this just wraps an ASTNode, but in the future it will allow us to model counters that cannot simply hang off ASTNodes, e.g error branch counters.
Additionally, fix up some cases where we could pass null to
emitProfilerIncrement&loadProfilerCount, as that's now an assertion failure.