Skip to content

[PrunedLiveness] Addressed boundary TODO. #61567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

With guaranteed phis, we'll be able to encounter cases where the last users are BranchInsts which use but don't consume a value. But even without them, we can still test the API.

@nate-chandler nate-chandler force-pushed the pruned-liveness-boundary-todo branch 2 times, most recently from 05b240c to 6df53e4 Compare October 13, 2022 20:03
@nate-chandler
Copy link
Contributor Author

@swift-ci please test macOS platform

@nate-chandler nate-chandler force-pushed the pruned-liveness-boundary-todo branch from 6df53e4 to 86c51c1 Compare October 14, 2022 17:46
@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macOS platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

With guaranteed phis, we'll be able to encounter cases where the last
users are BranchInsts which use but don't consume a value.  But even
without them, we can still test the API.
@nate-chandler nate-chandler force-pushed the pruned-liveness-boundary-todo branch from 86c51c1 to c2f354e Compare October 17, 2022 23:50
@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit d3f6314 into swiftlang:main Oct 18, 2022
@nate-chandler nate-chandler deleted the pruned-liveness-boundary-todo branch July 5, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants