[cxx-interop] Optimize CxxIterator and CxxSequence
#61577
Merged
+21
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please benchmark |
Code size: -Osize
Performance (x86_64): -Onone
Code size: -swiftlibs |
|
These two benchmarks should not be affected by the change, since they use raw C++ iterators. I'm not sure why the results have changed:
|
|
@swift-ci please benchmark |
hyp
reviewed
Oct 14, 2022
1. Instead of storing the C++ collection within `class CxxIterator`, store a boxed C++ collection and make `CxxIterator` a struct. This enables a number of Swift optimizations for iterators, while preserving the guarantee that the C++ collection is not copied or moved in memory (which would invalidate iterators). 2. Make `sequence` parameter shared. This avoids a second copy of the C++ collection when initializing `CxxIterator`. Credits to Alex Lorenz for this idea!
Performance (x86_64): -O
Code size: -O
Performance (x86_64): -Osize
Code size: -Osize
Performance (x86_64): -Onone
Code size: -swiftlibs |
egorzhdan
force-pushed
the
egorzhdan/cxx-iterator-boxing
branch
from
b8ab3d1 to
10b7057
Compare
|
@swift-ci please smoke test |
|
@swift-ci please benchmark |
|
@swift-ci please smoke test Windows |
It's just noise. Any benchmark under 100us is going to be mostly noise (maybe these ones are helpful to establish a baseline though). |
zoecarver
approved these changes
Oct 14, 2022
Performance (x86_64): -O
Code size: -O
Performance (x86_64): -Osize
Code size: -Osize
Performance (x86_64): -Onone
Code size: -swiftlibs |
|
300x improvement, that's what I like to see! 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class CxxIterator, store a boxed C++ collection and makeCxxIteratora struct. This enables a number of Swift optimizations for iterators, while preserving the guarantee that the C++ collection is not copied or moved in memory (which would invalidate iterators).sequenceparameter shared. This avoids a second copy of the C++ collection when initializingCxxIterator.Credits to Alex Lorenz for this idea!