Skip to content

[interop][SwiftToCxx] include the swiftToCxx shim header only when ac… #61605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

[interop][SwiftToCxx] include the swiftToCxx shim header only when ac… #61605

merged 1 commit into from
Oct 18, 2022

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Oct 17, 2022

…tually needed for reverse interop

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Oct 17, 2022
@hyp hyp requested review from egorzhdan and zoecarver October 17, 2022 20:15
@hyp
Copy link
Contributor Author

hyp commented Oct 17, 2022

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Oct 17, 2022

@swift-ci please test source compatibility

zoecarver
zoecarver approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you (maybe as a follow up) add a test that includes the generated header as an objc++ file?

@hyp
Copy link
Contributor Author

hyp commented Oct 18, 2022

Can you (maybe as a follow up) add a test that includes the generated header as an objc++ file?

That's tested by the empty.swift test in PrintAsObjC.

@hyp hyp merged commit ee1f2fa into swiftlang:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver zoecarver approved these changes

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @zoecarver