-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Interop] [SwiftToCxx] Introduce Dynamic Cast to swift::Error #61626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hyp
merged 9 commits into
swiftlang:main
from
Robertorosmaninho:cxx-interop/DynamicCastToSwiftError
Oct 28, 2022
Merged
[Interop] [SwiftToCxx] Introduce Dynamic Cast to swift::Error #61626
hyp
merged 9 commits into
swiftlang:main
from
Robertorosmaninho:cxx-interop/DynamicCastToSwiftError
Oct 28, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
hyp
reviewed
Oct 21, 2022
b191d9f
to
cb31700
Compare
@swift-ci please test |
hyp
reviewed
Oct 21, 2022
hyp
reviewed
Oct 21, 2022
test/Interop/SwiftToCxx/functions/swift-functions-errors-execution.cpp
Outdated
Show resolved
Hide resolved
@swift-ci please test |
1 similar comment
@swift-ci please test |
@swift-ci please test |
@swift-ci please test source compatibility |
@swift-ci please test |
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification allow the user to cast a generic
swift::Error
to its own Error and identify which case was catch!