[docs] GettingStarted.md: Do not suggest to run tests when building toolchain #61633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AnthonyLatsis
commented
Oct 19, 2022
AnthonyLatsis
commented
- Running the entire test suite is unnecessarily burdensome for newcomers, given the already considerable build times.
- Test failures are not a beginner-friendly indication of an out-of-sync checkout, nor is such an indication generally worth the expenses.
- We do not want a known issue to block anyone’s workflow.
xedin
reviewed
Oct 19, 2022
|
Just noticed that GitHub created a branch in Apple’s repo rather than my fork. Starting to feel like I’ll never do stuff like this in the browser again. |
hborla
approved these changes
Oct 19, 2022
CodaFi
approved these changes
Oct 19, 2022
xedin
approved these changes
Oct 19, 2022
LucianoPAlmeida
approved these changes
Oct 19, 2022
…oolchain * Running the entire test suite is unnecessarily burdensome for newcomers, given the already considerable build times. * Test failures are not a beginner-friendly indication of an out-of-sync checkout, nor is such an indication generally worth the expenses. * We do not want a known issue to block anyone’s workflow.
AnthonyLatsis
force-pushed
the
AnthonyLatsis-patch-1
branch
from
eee197c to
d64def2
Compare
AnthonyLatsis
commented
Oct 19, 2022
Comment on lines
+508
to
-525
| In the rare event that a local test failure happens to be unrelated to your | ||
| changes (is not due to stale binaries and reproduces without your changes), | ||
| there is a good chance that it has already been caught by our continuous | ||
| integration infrastructure, and it may be ignored. | ||
|
|
||
| If you want to rerun all the tests, you can either rebuild the whole project | ||
| and use `lit.py` without `--filter` or use `run-test` to handle both aspects. | ||
|
|
||
| Recall the baseline failures mentioned in | ||
| [the build section](#the-actual-build). If your baseline had failing tests, make | ||
| sure you compare the failures seen after your changes to the baseline. If some | ||
| test failures look totally unrelated to your changes, there is a good chance | ||
| that they were already failing as part of the baseline. | ||
|
|
There was a problem hiding this comment.
Spotted this now-dead reference and reworded the paragraph.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.