[cxx-interop] Emit IR for destructors of temporary C++ values #61638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
THanks! |
hyp
approved these changes
Oct 19, 2022
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
from
8bc6960 to
a9c00a8
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
from
a9c00a8 to
41a0883
Compare
|
@swift-ci please smoke test Windows |
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
from
41a0883 to
9f16886
Compare
|
@swift-ci please smoke test Windows |
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
2 times, most recently
from
53cd232 to
6e30009
Compare
|
@swift-ci please smoke test |
hyp
reviewed
Oct 20, 2022
test/Interop/Cxx/class/destructors-with-temporary-values-irgen.swift
Outdated
Show resolved
Hide resolved
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
from
6e30009 to
771815d
Compare
|
@swift-ci please smoke test Windows |
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
from
771815d to
5e2ac13
Compare
|
@swift-ci please smoke test Windows |
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
from
5e2ac13 to
1c0d24f
Compare
|
@swift-ci please smoke test Windows |
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
from
1c0d24f to
b685817
Compare
|
@swift-ci please smoke test Windows |
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
from
b685817 to
c7e7594
Compare
|
@swift-ci please smoke test Windows |
This fixes the "undefined reference" linker errors. rdar://101092732
egorzhdan
force-pushed
the
egorzhdan/cxx-destructor-irgen
branch
from
c7e7594 to
93e7427
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "undefined reference" linker errors.
rdar://101092732