-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Follow-up changes for function effects #61641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eeckstein
merged 15 commits into
swiftlang:main
from
eeckstein:side-effect-improvements
Oct 20, 2022
Merged
Follow-up changes for function effects #61641
eeckstein
merged 15 commits into
swiftlang:main
from
eeckstein:side-effect-improvements
Oct 20, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci test |
…nKind::Effects` This invalidation kind is used when a compute-effects pass changes function effects. Also, let optimization passes which don't change effects only invalidate the `FunctionBody` and not `Everything`.
By adding a `~=` operator with `StaticString`
It has already been ignored for value types, but not for address types.
This avoids sending a change notification which can trigger unnecessary other invalidations.
…TrivialNonPointer` This is consistent with `Type.isTrivial`. Also, introduce corresponding properties in `Value`: `hasTrivialType` and `hasTrivialNonPointerType`, because 1. It's less to type than `Type.isTrivial(in: function)` because `Value` knows in which function it is. 2. It fixes the corner case where value is an `Undef`, which has not parent function.
…cs("optimize.no.crossmodule")`
add `Function.getSideEffects(forArgument:,atIndex:,withConvention:)`
Conservatively model those effects as "destroy" effects.
This retrieves the side effect information from the function effects.
The underlying problem has been fixed
1017d90
to
9ae24f8
Compare
@swift-ci test |
@swift-ci benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a lot of small improvements and cleanups related to escape and side effects.
For details see commit messages.