[NFC] OSSA jump-threading support #61648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
The OSSA verifier was never enabled for block terminators. So we could blindly give terminator results any ownership without knowing.
Begin adding support for OSSA to checked-cast jump-threading based on the new ownership utilities. TODO: Finish migrating to the new utilities in OwnershipOptUtils. Ensure full unit test coverage.
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@meg-gupta the checked-cast jump-threading tests are updated for guaranteed phis and all enabled. I'm ready to merge it. There is a FIXME to better organize the tests: And one extra copy that we shouldn't need when RAUW is fixed: |
|
@swift-ci test macOS platform |
1 similar comment
|
@swift-ci test macOS platform |
meg-gupta
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few commits from 1 year ago. I didn't check them in at the time because the underlying OSSA support was not robust enough to handle all cases that could be exposed, and there was no good way to unit test those utilities.
I'm merging them now under a flag so we can begin simultaneously testing OSSA simplify-cfg and adding unit tests for OSSA.