Removed deinit barrier workaround. #61654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
shrink_borrow_scope/handle_barrier_merge_terminators
branch
from
f17d189 to
54a1d94
Compare
nate-chandler
force-pushed
the
shrink_borrow_scope/handle_barrier_merge_terminators
branch
from
54a1d94 to
435048a
Compare
Checked that a barrier terminator's successor isn't a merge point.
Previously, to workaround an issue with ShrinkBorrowScope (where it assumed a reasonable definition of isDeinitBarrier), a placeholder version of the function was added. It is now removed by moving the implementation of a version of that predicate back to C++.
nate-chandler
force-pushed
the
shrink_borrow_scope/handle_barrier_merge_terminators
branch
from
435048a to
f98917b
Compare
|
@swift-ci please test |
nate-chandler
changed the title
nate-chandler
deleted the
shrink_borrow_scope/handle_barrier_merge_terminators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, to workaround an issue with ShrinkBorrowScope (where it assumed a reasonable definition of isDeinitBarrier), a placeholder version of the function was added. It is now removed by moving the implementation of a version of that predicate back to C++.