Skip to content

build: fix syntax error in FreeBSD section of configure_sdk_unix #61661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

build: fix syntax error in FreeBSD section of configure_sdk_unix #61661

merged 1 commit into from
Oct 21, 2022

Conversation

mhjacobson
Copy link
Contributor

Fix syntax error in the FreeBSD section of configure_sdk_unix. The syntax error results in this error during configuration:

CMake Error at cmake/modules/SwiftConfigureSDK.cmake:336 (if):
  if given arguments:

    "CMAKE_HOST_SYSTEM_NAME" "NOT" "STREQUAL" "FreeBSD"

  Unknown arguments specified
Call Stack (most recent call first):
  CMakeLists.txt:854 (configure_sdk_unix)


-- Configuring incomplete, errors occurred!

@egorzhdan egorzhdan requested a review from compnerd October 21, 2022 11:33
compnerd
compnerd approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, nice catch.

@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd compnerd merged commit 31ceead into swiftlang:main Oct 21, 2022
@mhjacobson mhjacobson mentioned this pull request Oct 27, 2022
Merged
@mhjacobson mhjacobson mentioned this pull request Nov 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhjacobson @compnerd