Followup for #61505 #61676
Merged
Followup for #61505 #61676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
…port" This reverts commit 4acfd4d.
…pes for @guaranteed forwarding phis" This reverts commit dfbb2bd.
…ction arg when used as a phi operand
|
@swift-ci test |
|
@meg-gupta did you mean to revert two commits in this PR? On the verifier revert: Can we just verify that the operand of a What's going on with the ConditionVerifier revert? |
|
@atrick ConditionForwarding was turned off for @guaranteed function arguments, I reverted it, so they can be optimized too. CopyPropagation needs to be fixed to clean up unnecessary begin_borrows after doing some @owned to @guaranteed transformation. I'll enable the verifier assert after that is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61505 had leftover places where begin_borrows were being created to pass a @guaranteed function argument as a phi operand. This PR gets rid of them. Because with @guaranteed forwarding phi support, no @guaranteed value needs additional borrow scope for being used as a phi operand.