[move-only] Change type lowering to ensure we use {retain,release}_value instead of strong_{retain,release} #61711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just an oversight I discovered when writing the enum deinit tests.
|
@swift-ci test |
|
Problem is test needs to run without asserts due to the irgen check. |
|
*run with asserts. |
…e}_value instead of strong_{retain,release} for move only enum/structs
This ensures that when we hit IRGen, if we have a type with trivial contents, we
emit nothing and if we have a type with non-trivial contents, we just emit
recursive retain/release as appropriate.
This is the last bug holding up the buffer view prototype from Guilliume.
gottesmm
force-pushed
the
pr-8e7407db044609579456f02173cda0dbd572217d
branch
from
cd98a4f to
285f03e
Compare
|
@swift-ci test |
|
@swift-ci build toolchain |
|
@swift-ci test |
|
@swift-ci build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last thing stopping the prototype from buffer view from working. I also fixed a small issue around SILGen for move only enums constructed from trivial literals in let initialization. Added tests for all of the relevant parts.