[AddressLowering] Storage root inherits lexical. #61747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that it's not a missed case. It changes representation.
The switch_enum_addr consumes its operand so a copy is needed.
|
@swift-ci please smoke test macOS platform |
nate-chandler
force-pushed
the
opaque-values/1/20221014
branch
2 times, most recently
from
a966c1c to
4ddc754
Compare
|
@swift-ci please test |
nate-chandler
changed the title
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
atrick
approved these changes
Oct 27, 2022
| @@ -2884,6 +2884,9 @@ ReturnInst::ReturnInst(SILFunction &func, SILDebugLocation debugLoc, | |||
|
|
|||
| bool OwnershipForwardingMixin::hasSameRepresentation(SILInstruction *inst) { | |||
| switch (inst->getKind()) { | |||
| // Explicitly list instructions which definitely involve a representation | |||
| // change. | |||
| case SILInstructionKind::SwitchEnumInst: | |||
There was a problem hiding this comment.
Nice practice. Too bad we don't do it elsewhere.
| @@ -2776,6 +2776,13 @@ void UseRewriter::visitBeginBorrowInst(BeginBorrowInst *borrow) { | |||
| allocStack->setIsLexical(); | |||
| return; | |||
| } | |||
| auto storage = AccessStorageWithBase::compute(address); | |||
There was a problem hiding this comment.
If you're not interested in AccessStorage, you should be able to use getAccessBase or AccessBase::compute
There was a problem hiding this comment.
Oh, perfect! Changed to getAccessBase and checked propagated the lexical flag to it if its an alloc_stack and allowed it if it was a function argument. Added a struct extract test case for both an opaque value that needed an alloc_stack and one that was passed in.
When a `begin_borrow [lexical]` is lowered, the lifetime that it describes can't be shortened (or eliminated) when lowering. In some cases, though, there will not be an alloc_stack corresponding directly to the value being borrowed. In these cases, mark the whole aggregate lexical.
nate-chandler
force-pushed
the
opaque-values/1/20221014
branch
from
4ddc754 to
c766956
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
begin_borrow [lexical]is lowered, the lifetime that it describes can't be shortened (or eliminated) when lowering. In some cases, though, there will not be an alloc_stack corresponding directly to the value being borrowed.In these cases, mark the whole aggregate lexical.