IRGen: Use clang's codegen for protocol decls #61750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are certain protocol method decls types that swift does not import today. ``` @protocol Incomplete - (id)getObjectFromVarArgs:(id)first, ...; @EnD ``` Furthermore, the old method also emitted duplicate entries for protocols methods when Swift synthesized methods for diagnosics. We won't import this method into Swift. So if we emit protocol metadata from swift delcs we would generate incomplete records. rdar://60888524
|
@swift-ci test |
|
@swift-ci test source compat |
|
@swift-ci test source compatibility release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain protocol method decls types that swift does not import today.
Furthermore, the old method also emitted duplicate entries for protocols methods when Swift synthesized methods for diagnosics.
We won't import this method into Swift. So if we emit protocol metadata from swift delcs we would generate incomplete records.
rdar://60888524