Skip to content

CMake: Break some dependency cycles between compiler libraries #61753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

CMake: Break some dependency cycles between compiler libraries #61753

merged 1 commit into from
Oct 27, 2022

Conversation

tshortli
Copy link
Contributor

  • Remove cycle between swiftIRGen and swiftTBGen.
  • Remove cycle between swiftSIL and swiftSerialization.
  • Remove cycle between swiftFrontendTool and swiftIDE.

@tshortli
CMake: Break some dependency cycles between compiler libraries.
57ebca8 
- Remove cycle between swiftIRGen and swiftTBGen.
- Remove cycle between swiftSIL and swiftSerialization.
- Remove cycle between swiftFrontendTool and swiftIDE.
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli tshortli requested a review from etcwilde October 26, 2022 22:16
@etcwilde
Copy link
Member

@swift-ci Build Toolchain macOS Platform

etcwilde
etcwilde approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it. Assuming the tests all pass and we can build a successful toolchain build, LGTM!

@tshortli
Copy link
Contributor Author

@swift-ci please smoke test Windows

@tshortli tshortli merged commit 80b54a8 into swiftlang:main Oct 27, 2022
@tshortli tshortli deleted the break-cmake-cycles branch October 27, 2022 03:35
@tshortli tshortli mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde etcwilde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshortli @etcwilde