Skip to content

Interop: Untangle circular dependency introduced by #59787 #61770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

The changes for #59787 introduced a circular depenendcy between the SIL library and the SILGen library. I have undone this in the cheapest way possible as I don't have bandwidth to look into a more correct fix at the moment.

The changes for swiftlang#59787 introduced a circular depenendcy between the SIL library and the SILGen library. I have undone this in the cheapest way possible as I don't have bandwidth to look into a more correct fix at the moment.
@tshortli tshortli requested a review from hyp October 27, 2022 20:19
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli tshortli changed the title Interop: Untangle circular dependency introduced by #59787 Interop: Untangle circular dependency introduced by https://github.com/apple/swift/pull/59787 Oct 27, 2022
@tshortli tshortli changed the title Interop: Untangle circular dependency introduced by https://github.com/apple/swift/pull/59787 Interop: Untangle circular dependency introduced by #59787 Oct 27, 2022
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test macOS

@tshortli tshortli merged commit 53ac896 into swiftlang:main Oct 28, 2022
@tshortli tshortli deleted the fix-sil-silgen-circular-dependency branch October 28, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant