SIL: Perform move-only diag passes after ClosureLifetimeFixup. #61772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClosureLifetimeFixup finalizes the lifetimes of nonescaping closures, which allows us to analyze their captures as borrows and permit move- only types to be captured by them.
|
@swift-ci Please test |
gottesmm
reviewed
Oct 27, 2022
| // pass. This will happen when OSSA is no longer eliminated before the | ||
| // optimizer pipeline is run implying we can put a pass that requires OSSA | ||
| // there. | ||
| const auto &Options = P.getOptions(); |
There was a problem hiding this comment.
Can you add a test that shows this behavior? Then I am happy.
There was a problem hiding this comment.
I talked with JoeG offline about this. They mentioned that this is just the first part of a larger fix so it isn't time yet to add a test for this behavior. So... LGTM!
There was a problem hiding this comment.
There is no behavior change yet.
gottesmm
approved these changes
Oct 27, 2022
|
@swift-ci Please clean test |
1 similar comment
|
@swift-ci Please clean test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClosureLifetimeFixup finalizes the lifetimes of nonescaping closures, which allows us to analyze their captures as borrows and permit move- only types to be captured by them.