Skip to content

[Serialization] Write in the binary swiftmodule file whether it was rebuilt from a swiftinterface #61789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2022

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Oct 28, 2022

Keep track of whether a swiftmodule was built from a swiftinterface or from source. This information will be used to change how the compiler deals with those dependencies.

Also tweak the fan favorite DESERIALIZATION FAILURE error message to add whether the swiftmodule was rebuilt and if it's library-evolution enabled.

Extracting this logic in this PR as it's used by both #61649 and #61765.

xymus added 2 commits October 27, 2022 18:51
…terface

This information will allow us to distinguish swiftmodule built from
source vs swiftinterface.
This adds information about whether the module was built from source or
from a swiftinterface, whether it's resilient or not, and tweaks the
format.
@xymus xymus requested review from bnbarham and tshortli October 28, 2022 16:02
@xymus
Copy link
Contributor Author

xymus commented Oct 28, 2022

@swift-ci Please smoke test

@xymus
Copy link
Contributor Author

xymus commented Oct 28, 2022

@swift-ci Please smoke test macOS

@xymus
Copy link
Contributor Author

xymus commented Oct 28, 2022

@swift-ci Please smoke test macOS

1 similar comment
@xymus
Copy link
Contributor Author

xymus commented Oct 29, 2022

@swift-ci Please smoke test macOS

@xymus xymus merged commit 34779d4 into swiftlang:main Oct 29, 2022
@xymus xymus deleted the serial-rebuilt-bit branch October 29, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants