NFC: add code owners for C++ interop #61821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
commented
Oct 31, 2022
| @@ -6,3 +6,8 @@ | |||
| include/swift/Parse @ahoppen @bnbarham @CodaFi @DougGregor @rintaro | |||
| lib/Parse @ahoppen @bnbarham @CodaFi @DougGregor @rintaro | |||
| test/Parse @ahoppen @bnbarham @CodaFi @DougGregor @rintaro | |||
|
|
|||
| # C++ Interop | |||
There was a problem hiding this comment.
@zoecarver @hyp do you think we should also auto-add ourselves as reviewers for all of ClangImporter? We could also try to filter the source files within ClangImporter that are related to C++ interop if that makes sense.
There was a problem hiding this comment.
All of ClangImporter/PrintAsClang might make sense, but I think that warrants a wider discussion with the Swift team, they might want to add an additional code owner there as well.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
hyp
reviewed
Nov 1, 2022
This teaches GitHub to automatically add the three of us as reviewers to patches that alter the source files related to C++ interop. This doesn't mean that all of the people added as reviewers must necessarily review a patch, is just makes it more straightforward for folks who don't have commit access to request reviews for their patches.
egorzhdan
force-pushed
the
egorzhdan/cxx-codeowners
branch
from
2057eac to
ea98bae
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This teaches GitHub to automatically add the three of us as reviewers to patches that alter the source files specific to C++ interop.
This doesn't mean that all of the people added as reviewers must necessarily review a patch, is just makes it more straightforward for folks who don't have commit access to request reviews for their patches.