[cxx-interop] Emit IR for virtual methods #61828
Merged
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-ir-virtual
branch
from
78574c5 to
4e343ea
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-ir-virtual
branch
from
4e343ea to
7b7c010
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-ir-virtual
branch
from
7b7c010 to
71e5ce7
Compare
|
@swift-ci please smoke test |
Even if a virtual method is not used directly from Swift, it might get emitted into the vtable, and in that case the IR for it should be emitted to avoid linker errors. Fixes #61730.
egorzhdan
force-pushed
the
egorzhdan/cxx-ir-virtual
branch
from
71e5ce7 to
6ca60b0
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
Hooray! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if a virtual method is not used directly from Swift, it might get emitted into the vtable, and in that case the IR for it should be emitted to avoid linker errors.
Fixes #61730.