Forcibly disable static constant array emission for now #61830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code currently uses the "empty array" metadata for static arrays (because the "empty array" can never be freed and the metadata on the array storage is not actually used in Swift). But that doesn't work if the array is passed to Objective-C, which does rely on the metadata. So Objective-C code would see bridged arrays of this type as empty. Workaround for: rdar://101126543
|
@swift-ci Please test |
mikeash
approved these changes
Oct 31, 2022
|
@swift-ci Please test macOS platform |
|
@swift-ci Please test macOS platform |
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Nov 2, 2022
This is a followup of swiftlang#61830
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Nov 9, 2022
This is a followup of swiftlang#61830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code currently uses the "empty array" metadata for static arrays (because the "empty array" can never be freed and the metadata on the array storage is not actually used in Swift).
But that doesn't work if the array is passed to Objective-C, which does rely on the metadata. So Objective-C code would see bridged arrays of this type as empty.
Workaround for: rdar://101126543 and rdar://100480289