Skip to content

Enable running tests from test/Concurrency/ directory in freestanding/minimal presets #61835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kubamracek
Copy link
Contributor

@kubamracek kubamracek commented Oct 31, 2022

rdar://101768542

@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

2 similar comments
@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@kubamracek kubamracek force-pushed the run-concurrency-tests-in-freestanding branch from abe1180 to d10ff2f Compare November 1, 2022 19:19
@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@kubamracek kubamracek force-pushed the run-concurrency-tests-in-freestanding branch from d10ff2f to 7f12759 Compare November 4, 2022 00:14
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to have these running now.

@kubamracek kubamracek merged commit 7853184 into swiftlang:main Nov 4, 2022
@kubamracek kubamracek deleted the run-concurrency-tests-in-freestanding branch November 4, 2022 16:08
meg-gupta pushed a commit to meg-gupta/swift that referenced this pull request Nov 9, 2022
…/minimal presets (swiftlang#61835)

* Enable running tests from test/Concurrency/ directory in freestanding/minimal presets

* Mark failing Concurrency tests as XFAIL/SKIP on freestanding/minimal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants