[cxx-interop] Avoid a ClangImporter dependency on Sema #61847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
My recent change started linking ClangImporter with Sema, which accidentally introduced a circular dependency between the two. This patch avoid the usage of type checker logic from ClangImporter's automatic protocol conformance logic. rdar://101763817
egorzhdan
force-pushed
the
egorzhdan/cxx-dependency-on-sema
branch
from
1b0c19e to
7f6fcf6
Compare
|
@swift-ci please smoke test |
hyp
approved these changes
Nov 1, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks @tshortli! Let me reproduce and fix this locally. |
Thanks! Note that this will only reproduce on Linux, so if you're not set up to develop on Linux it may just be easier to let CI validate. |
|
@swift-ci please smoke test |
zoecarver
approved these changes
Nov 1, 2022
This comment was marked as resolved.
This comment was marked as resolved.
egorzhdan
force-pushed
the
egorzhdan/cxx-dependency-on-sema
branch
from
0195f26 to
4bdd72f
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-dependency-on-sema
branch
from
4bdd72f to
a7f00d6
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent change started linking ClangImporter with Sema, which accidentally introduced a circular dependency between the two.
This patch avoid the usage of type checker logic from ClangImporter's automatic protocol conformance logic.
rdar://101763817