Skip to content

[cxx-interop] Fix nullptr casts in auto-conformance logic #61853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

egorzhdan
Copy link
Contributor

This fixes a couple cases of cases where a malformed C++ iterator type would trigger an assertion in ClangImporter: Assertion failed: (Val && "isa<> used on a null pointer").

This fixes a couple cases of cases where a malformed C++ iterator type would trigger an assertion in ClangImporter: `Assertion failed: (Val && "isa<> used on a null pointer")`.
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Nov 1, 2022
@egorzhdan egorzhdan requested review from hyp and zoecarver November 1, 2022 22:38
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay 🎊🥳

@egorzhdan egorzhdan merged commit dc3978f into main Nov 2, 2022
@egorzhdan egorzhdan deleted the egorzhdan/cxx-rac-iterator-nullptr branch November 2, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants