[TypeChecker] PropertyWrappers: Re-parent any captures from wrapped t… #61870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o backing property
In the situations where initializer of property wrapper attribute
has any kind of captures i.e. `{ [x = ...] ... }` they should be
re-parented to the backing property because that's actually
where the expression gets used - initializer of the backing
property, e.g:
```swift
struct Test {
@wrapper([1, 2, 3].map { [x = 42] ... })
var x: Int
}
```
is transformed into:
```swift
struct Test {
var x: Int {
get { ... }
set { ... }
}
var _x: Wrapper<Int> = Wrapper(wrappedValue: [1, 2, 3].map { [x = 42] ... })
}
```
Resolves: swiftlang#61570
Resolves: rdar://problem/101813792
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Nov 2, 2022
|
Looks like sandboxing issue with protobuf project has been fixed and it's now UPASS'ing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o backing property
In the situations where initializer of property wrapper attribute has any kind of captures i.e.
{ [x = ...] ... }they should be re-parented to the backing property because that's actually where the expression gets used - initializer of the backing property, e.g:is transformed into:
Resolves: #61570
Resolves: rdar://problem/101813792