[cxx-interop] Add explicit typealiases to CxxRandomAccessCollection
#61878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
commented
Nov 2, 2022
| @@ -31,6 +31,9 @@ extension UnsafeMutablePointer: UnsafeCxxRandomAccessIterator {} | |||
| public protocol CxxRandomAccessCollection: CxxSequence, RandomAccessCollection { | |||
| override associatedtype RawIterator: UnsafeCxxRandomAccessIterator | |||
| override associatedtype Element = RawIterator.Pointee | |||
| override associatedtype Index = Int | |||
| override associatedtype Indices = DefaultIndices<Self> | |||
| override associatedtype SubSequence = Slice<Self> | |||
There was a problem hiding this comment.
We can also create a special kind of Slice for C++ collections which would box the collection to avoid extra copies. I'll do that a bit later.
|
does this need any testing? |
|
This is covered by an existing test: |
|
@swift-ci please smoke test macOS |
This will help us to auto-generate conformances to `CxxRandomAccessCollection`, since synthesized conformances must have all of their witnesses explicitly provided.
egorzhdan
force-pushed
the
egorzhdan/cxx-rac-overrides
branch
from
5bce831 to
5359c13
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us to auto-generate conformances to
CxxRandomAccessCollection, since synthesized conformances must have all of their witnesses explicitly provided.