[OpaqueValues] Handle Builtin.copy. #61879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the API was only on FullApplySite, but it is useful to be able to insert code after a partial_apply as well.
Rather than being able to handle only to FullApplySites, it now handles PartialApplyInsts as well.
Use the CallArgRewriter to rewrite uses by partial_apply insts just as uses by apply insts, etc., are rewritten.
When branching to the exit block, flatten an @out tuple return value into its components, as is done for all other return values. In the exit block, when constructing the @out tuple to return, visit the tuple-type-tree of the return value to reconstruct the nested tuple structure: @out tuple returns are not flattened, unlike regular tuple returns.
|
@swift-ci please test |
Specify the operand ownership of the Builtin differently depending on whether lowered addresses are used. Handle rewriting the value version of the builtin as the address version of the builtin in AddressLowering.
nate-chandler
force-pushed
the
opaque-values/1/20221101
branch
from
cb94d12 to
e357fb4
Compare
|
@swift-ci please test |
|
LGTM Except, as I mentioned in two other PRs 😆, we should (in the not too distant future) remove Builtin.copy and all these special cases to handle it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #61846 .
Specify the operand ownership of the Builtin differently depending on whether lowered addresses are used. Handle rewriting the value version of the builtin as the address version of the builtin in AddressLowering.