Skip to content

[cxx-interop] Synthesize conformances to CxxRandomAccessCollection #61909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

egorzhdan
Copy link
Contributor

This makes ClangImporter automatically conform C++ collection types to Cxx.CxxRandomAccessCollection protocol.

We consider a C++ sequence type to be a random access collection type its iterator conforms to UnsafeCxxRandomAccessIterator.

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Nov 3, 2022
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

This makes ClangImporter automatically conform C++ collection types to `Cxx.CxxRandomAccessCollection` protocol.

We consider a C++ sequence type to be a random access collection type its iterator conforms to `UnsafeCxxRandomAccessIterator`.
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-synthesize-rac branch from c6ebdc6 to 3cf8421 Compare November 3, 2022 19:01
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test Linux

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test Windows

2 similar comments
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test Windows

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test Windows

@egorzhdan egorzhdan merged commit 1a1afeb into main Nov 4, 2022
@egorzhdan egorzhdan deleted the egorzhdan/cxx-synthesize-rac branch November 4, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants