Skip to content

[interop][SwiftToCxx] add support for constructing generic enum cases… #61913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2022
Merged

[interop][SwiftToCxx] add support for constructing generic enum cases… #61913

merged 1 commit into from
Nov 4, 2022

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Nov 3, 2022

… in C++

We only support cases with no payload, or one associated value still

@hyp
[interop][SwiftToCxx] add support for constructing generic enum cases…
8336edd 
… in C++

We only support cases with no payload, or one associated value still
@hyp hyp added the c++ interop Feature: Interoperability with C++ label Nov 3, 2022
@hyp
Copy link
Contributor Author

hyp commented Nov 3, 2022

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Nov 3, 2022

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Nov 3, 2022

This allows us to construct Optional::some or Optional::none in C++

@hyp
Copy link
Contributor Author

hyp commented Nov 4, 2022

@swift-ci please test windows platform

@hyp
Copy link
Contributor Author

hyp commented Nov 4, 2022

Source compatibility failures are unrelated, will merge:

========================================
Failures:
  FAIL: CoreStore, 4.2, 286360, CoreStore watchOS, generic/platform=watchOS
  FAIL: CoreStore, 4.2, 286360, CoreStore tvOS, generic/platform=tvOS
  FAIL: CoreStore, 4.2, 286360, CoreStore OSX, generic/platform=macOS
  FAIL: CoreStore, 4.2, 286360, CoreStore iOS, generic/platform=iOS
  FAIL: CoreStore, 4.0, 83e608, CoreStore watchOS, generic/platform=watchOS
  FAIL: CoreStore, 4.0, 83e608, CoreStore tvOS, generic/platform=tvOS
  FAIL: CoreStore, 4.0, 83e608, CoreStore OSX, generic/platform=macOS
  FAIL: CoreStore, 4.0, 83e608, CoreStore iOS, generic/platform=iOS
========================================

@hyp hyp merged commit a0d8ba2 into swiftlang:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hyp