Inherit parent's extra Clang arguments when creating an interface build sub-invocation. #61919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
tshortli
approved these changes
Nov 3, 2022
artemcm
force-pushed
the
InheritExtraClangStateForInterfaceSubInvocation
branch
from
0711145 to
703a3fb
Compare
nkcsgexi
approved these changes
Nov 4, 2022
artemcm
force-pushed
the
InheritExtraClangStateForInterfaceSubInvocation
branch
from
703a3fb to
9934c3b
Compare
|
@swift-ci test |
artemcm
force-pushed
the
InheritExtraClangStateForInterfaceSubInvocation
branch
from
9934c3b to
4bc0b00
Compare
|
@swift-ci test |
…ld sub-invocation. We would like to make sure they get propagated to downstream transitive Clang module dependencies also. Resolves rdar://101923680
artemcm
force-pushed
the
InheritExtraClangStateForInterfaceSubInvocation
branch
from
4bc0b00 to
d1cbf9c
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to make sure they get propagated to downstream transitive Clang module dependencies also. Otherwise they may not have sufficient context to build (such as missing parent invocation's macro definitions).
Resolves rdar://101923680