[CSApply] For-in: Extend try injector to handle erasure and opened …
#61920
+49
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…existential For synthesized `<async iterator>.next()` calls expression rewriter has to check whether witness is throwing and add `try` when necessary, in order to do that injector needs to look through opened existentials, erasures, and other implicitly injected AST nodes.
slavapestov
reviewed
Nov 3, 2022
| nextCall, nextCall->getType()); | ||
| // Cannot use `forEachChildExpr` here because we need to | ||
| // to wrap a call in `try` and then stop immediately after. | ||
| struct TryInjector : ASTWalker { |
There was a problem hiding this comment.
Instead of injecting 'try' can we just teach the effect checker to do the right thing with ForEachStmt? Seems like a lot of extra work just to appease it. SILGen ignores TryExpr.
There was a problem hiding this comment.
Maybe @etcwilde has some ideas how to do that but the last time I tried it couldn't make it happen due the fact that this code has been synthesized.
|
@swift-ci please test |
hborla
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…existential
For synthesized
<async iterator>.next()calls expression rewriterhas to check whether witness is throwing and add
trywhen necessary,in order to do that injector needs to look through opened existentials,
erasures, and other implicitly injected AST nodes.