Remove erroneous ELF note. #61931
Merged
Remove erroneous ELF note. #61931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ELF platforms we currently output an ELF note but with totally invalid contents. I tried experimenting to see whether it was possible to do it properly and tie the result into ReflectionContext, but it turns out to be a hard problem because of issues to do with cross-segment symbol references and relocations. The upshot is that I think for now it's best just to remove it. We might revisit this in future at some point; it would be good to be able to reliably find the Swift metadata just from the ELF Phdrs. rdar://101749382
|
@swift-ci Please smoke test |
mikeash
approved these changes
Nov 4, 2022
We aren't using this constant any more either. rdar://101749382
|
@swift-ci Please smoke test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ELF platforms we currently output an ELF note but with totally invalid contents. I tried experimenting to see whether it was possible to do it properly and tie the result into
ReflectionContext, but it turns out to be a hard problem because of issues to do with cross-segment symbol references and relocations.The upshot is that I think for now it's best just to remove it.
We might revisit this in future at some point; it would be good to be able to reliably find the Swift metadata just from the ELF
Phdrs.rdar://101749382