[move-only] Teach the object/address move operator checker to not check move only types. #61964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only types. move only types will already be checked by the move only checker and said checker will still see move_value as a consume so we are just eliminating an unnecessary double diagnostic. rdar://102056097
|
@swift-ci test |
…hen applying the move operator to move only vars. The reason why we are doing this is that we want move only addresses to be checked by the move only address checker and not the move operator address checker. rdar://102056097
gottesmm
force-pushed
the
pr-140968cb0578adfb1af5718b8468c8c391695642
branch
from
95e1e01 to
26db1f2
Compare
gottesmm
changed the title
|
@swift-ci test |
|
I decided to include in this PR the corresponding work that accomplishes the same thing for vars. It works in a slightly different manner by having us emit a copy_addr instead of a mark_must_check_unresolved. This then causes the difference in behavior. |
|
@swift-ci test macOS platform |
1 similar comment
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move only types will already be checked by the move only checker and said checker will still see move_value as a consume so we are just eliminating an unnecessary double diagnostic.
rdar://102056097