Skip to content

IRGen: Gracefully handle protocol forward declaration references without definitions #61967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

IRGen: Gracefully handle protocol forward declaration references without definitions #61967

merged 1 commit into from
Nov 8, 2022

Conversation

aschwaighofer
Copy link
Contributor 

 @protocol DeclarationOnly;

 @protocol DeclarationOnlyUser<DeclarationOnly>
 - (void) printIt;
 @end

This should not be neccessary, but the compiler currently accepts cases like the one in the test case added.

rdar://101828847

@aschwaighofer
IRGen: Gracefully handle protocol forward declaration references with…
850f65c 
…out definitions

```
 @protocol DeclarationOnly;

 @protocol DeclarationOnlyUser<DeclarationOnly>
 - (void) printIt;
 @EnD
```

This should not be neccessary, but the compiler currently accepts cases
like the one in the test case added.

rdar://101828847
@aschwaighofer aschwaighofer marked this pull request as ready for review November 7, 2022 22:42
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@aschwaighofer
Copy link
Contributor Author

@swift-ci test macOS

@aschwaighofer
Copy link
Contributor Author

@swift-ci test linux

@aschwaighofer aschwaighofer merged commit 02c2ab4 into swiftlang:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aschwaighofer