tests: fix misspelled check prefixes #61978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the common error of using underscores instead of dashes. In the rebranch this is an error (lit got more picky), but it also makes sense to fix the tests in the main branch
|
@swift-ci smoke test |
* remove a NEXT requirement, because the optimizer now inserts an additional instruction * match optional `nonnull` attributes, which are inserted by the new LLVM (in rebranch)
They are inserted by the new LLVM (rebranch). It doesn't harm to match those attributes conditionally also in the main branch
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the rebranch this is an error (lit got more picky), but it also makes sense to fix the tests in the main branch
Also match optional
nonnullattributes. They are inserted by the new LLVM (rebranch). It doesn't harm to match those attributes conditionally also in the main branch.Also fix SILOptimizer/OSLogFullOptTest.swift and re-enable it. rdar://102078974