Disable _StringProcessing import in _CompilerPluginSupport #62042
Conversation
|
@swift-ci please smoke test |
rxwei
force-pushed
the
plugin-disable-sp-import
branch
from
f3394bc to
e68effb
Compare
|
@swift-ci please smoke test |
I thought the frontend would ignore unknown flags? @DougGregor |
|
You may need to detect if the compiler supports the flag, like Doug did for ASTGen -- #61889 |
rxwei
force-pushed
the
plugin-disable-sp-import
branch
from
e68effb to
3423e4a
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test macOS |
1 similar comment
|
@swift-ci please smoke test macOS |
Failed Tests (1):
lldb-api :: lang/swift/clangimporter/static_archive/TestSwiftStaticArchiveTwoSwiftmodules.py🙄 |
|
@swift-ci please smoke test macos |
| RESULT_VARIABLE | ||
| SWIFT_SUPPORTS_DISABLE_IMPLICIT_STRING_PROCESSING_MODULE_IMPORT) | ||
| if(NOT SWIFT_SUPPORTS_DISABLE_IMPLICIT_STRING_PROCESSING_MODULE_IMPORT) | ||
| add_compile_options( |
There was a problem hiding this comment.
It would be best to apply this directly to the target, to match what we did before
(also because calling add_compile_options after add_library will likely have no effect)
| add_compile_options( | |
| target_compile_options("${library_name}" PRIVATE |
There was a problem hiding this comment.
This is the same as #61889. Should I change this in ASTGen too?
There was a problem hiding this comment.
Not in this PR, it can be done at a later time -- I suspect in there it works because we call add_library after add_compile_options)
If you are concerned about having different code paths, you can move this section before add_library, and tackle changing the CMake command used at a later time
Reduce dependencies for rdar://102207474. Amends the incomplete patch in swiftlang#62042.
Reduce dependencies for rdar://102207474.